search

wangp / bower

A curses terminal client for the Notmuch email system
Other
119 stars 11 forks source link

Markspam #79

Closed xxxserxxx closed 3 years ago

xxxserxxx commented 3 years ago

I wanted a spam function (#78), and since key bindings are hard-coded here are the code changes. Two commits because I didn't catch the bulk tagged actions the first time.

wangp commented 3 years ago

I wouldn't mind hard coding a keybinding for this.

S is already taken for skipping quoted text in the thread/pager view; I don't know what the keybinding should be. Maybe $?

I don't think we need to toggle the spam tag. Rather, the action should perform all of +spam +deleted -inbox.

haasn commented 3 years ago

I don't think we need to toggle the spam tag. Rather, the action should perform all of +spam +deleted -inbox.

That seems redundant to me. I already exclude spam in ~/.notmuch-config, so for me simply marking it as spam is good enough. But YMMV.

xxxserxxx commented 3 years ago

S is already taken for skipping quoted text in the thread/pager view;

I was certain I did a search for it, but I must have missed one.

I don't think we need to toggle the spam tag

Ok.

Rather, the action should perform all of +spam +deleted -inbox.

Right, that's what I started with, then I came to the same conclusion as @haasn that, if I set the exact same tags every time, it's redundant. +spam should be enough, although I would add -unread because some external tools count the number of +unread messages. I posted #78, but have decided to change my pattern.

I'll submit a new pull request with the changes; I'll make it add spam and remove unread.