wangqianwen0418 / DRAVA

https://qianwen.info/DRAVA
5 stars 2 forks source link

fix: use reactive rendering to prevent re-mounting gosling component #1

Closed sehilyi closed 2 years ago

sehilyi commented 2 years ago

This PR uses experimental reactive rendering in Gosling to prevent re-mounting gosling components upon filtering samples. This fixes an issue that, whenever users filter samples, they can see a white empty space since the gosling component is unmounted and then mounted again.

sehilyi commented 2 years ago

@wangqianwen0418 Can you test if this change works as expected on your machine?

wangqianwen0418 commented 2 years ago

Thanks so much, Sehi! I will take a look shortly

wangqianwen0418 commented 2 years ago

Thanks, Sehi, experimental reactive rendering is very cool and the components work well as expected