wangqr / Aegisub

Win64 nightly builds available at GHA artifact, also at following link:
https://ftp.wangqr.tk/aegisub/
Other
799 stars 49 forks source link

Can't apply karaoke template from effect mod #66

Closed kedaitinh12 closed 3 years ago

kedaitinh12 commented 4 years ago

I Can't apply karaoke template from effect mod, but with old ver 3.2.2 i can apply complete with no error Ex file: https://drive.google.com/file/d/1OAg_3DWXtUpbJG_Xe-AbF8kZ20VHYrGy/view?usp=drivesdk

wangqr commented 4 years ago

The link you provided gives an error saying file not exist. Can you check that (could be the share permission)?

kedaitinh12 commented 4 years ago

The link you provided gives an error saying file not exist. Can you check that (could be the share permission)?

Sr, it's my fault. The link be ok: https://drive.google.com/file/d/1aSSeXEBAwhEoYHEirmHSA0ra0hMa75IH/view?usp=drivesdk

wangqr commented 4 years ago

The error message I see is:

Runtime error in template code: Expected 1 arguments, got 2
Code producing error: ci = { 0,0 }; cn = _G.unicode.len(orgline.text_stripped:gsub(" ",""))

Looks like the same as https://github.com/wangqr/Aegisub/issues/35#issuecomment-584026098

kedaitinh12 commented 3 years ago

The error message I see is:

Runtime error in template code: Expected 1 arguments, got 2
Code producing error: ci = { 0,0 }; cn = _G.unicode.len(orgline.text_stripped:gsub(" ",""))

Looks like the same as #35 (comment)

I see you don't fixed in new releases

wangqr commented 3 years ago

I'd say the issue is in the lua code, not Aegisub. It should be fixed by adding the parentheses in lua code. There is no point fixing this in Aegisub side.

kedaitinh12 commented 3 years ago

But why i can apply normally with old ver 3.2.2??

wangqr commented 3 years ago

3.2.2 uses an old version of luajit which is compatible with lua 5.1. The change to lua 5.2 compatible mode was made since release r8231 in 2014, long before the last official release r8942. I think fixing lua code is more reasonable and future proof, than downgrading lua just to support this specific issue.

kedaitinh12 commented 3 years ago

Oh

kedaitinh12 commented 3 years ago

I seen this thread use new Lua can apply normally and use new ffms2 without crash when open video with .opus audio. Can you to reply on Kainote and updated your aegisub completelly in the future

kedaitinh12 commented 3 years ago

https://github.com/bjakja/Kainote

kedaitinh12 commented 1 year ago

here fix this error https://github.com/wangqr/Aegisub/pull/156