wangsai / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request for experimental-gadgets-in-learner-view :: revised based on feedback #737

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Branch name: experimental-gadgets-in-learner-view

Link to the relevant commit(s):
https://code.google.com/p/oppia/source/detail?r=589cc5a921fae0f77a55af1d6ab38d12
da655fce&name=experimental-gadgets-in-learner-view

Purpose of code changes on this branch:
- Gadgets functional in learner view.

When reviewing my code changes, please focus on:
- Suggested solution for schema issue in AdviceBar.py?
- Any feedback?

After the review, I'll merge this branch into: TBD. Is this branch getting 
close to a point where it makes sense to merge to develop? (assuming schema 
issue gets resolved)

Original issue reported on code.google.com by anu...@google.com on 1 May 2015 at 7:21

GoogleCodeExporter commented 9 years ago
Review done. I think it is indeed close to merge, pending Amit's CSS 
suggestions, sorting out the todos/experimental stuff, and my question about 
per-state visibility. 

However, this branch contains a number of commits clearly marked "EXPERIMENTAL: 
NOT FOR MERGER INTO ANY STABLE BRANCH", and it would be weird to bring these 
into develop -- they should not be part of the main commit history. I think you 
might have to make a new branch and squash them.

Original comment by s...@seanlip.org on 2 May 2015 at 3:01