search

wangsai / oppia

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #750

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name: develop

Link to the relevant commit(s):
https://code.google.com/p/oppia/source/detail?r=5db30e01ccc522ec5acde41cd2f841d0
db0095b8&name=develop

Purpose of code changes on this branch:
https://code.google.com/p/oppia/issues/detail?id=747

When reviewing my code changes, please focus on:
Whether we should change it per Jacob's last suggestion to specialize the 
homepage title to just say "Oppia Gallery."

After the review, I'll merge this branch into: develop

Original issue reported on code.google.com by bhenn...@google.com on 12 May 2015 at 9:57

GoogleCodeExporter commented 9 years ago 
My apologies. I forgot to run the tests before pushing this, so this commit 
does break one test. The fix for that may be found in:

https://code.google.com/p/oppia/source/detail?r=dca0e5a527fba5f8b69060f8d4357079
9b6c7f00&name=develop

Original comment by bhenn...@google.com on 12 May 2015 at 10:54

GoogleCodeExporter commented 9 years ago 
Review done.

Re the question of specialization, yes, I think so. Could you do this in a 
separate branch?

Original comment by s...@google.com on 12 May 2015 at 11:24