wangscript / warp-persist

Automatically exported from code.google.com/p/warp-persist
0 stars 0 forks source link

PersistenceService.stop() #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
We should add this method (currently added for Hibernate), and document its
usage. People often forget to stop their persistence service.

Original issue reported on code.google.com by robbie.v...@gmail.com on 22 Aug 2008 at 12:18

GoogleCodeExporter commented 9 years ago
+1 this has been on my agenda for awhile. I suggest calling it shutdown() as 
stop() seems temporary for some 
reason.

Also wondering if it might be worthwhile to provide an auto-start/shutdown 
using SPR filter?

Original comment by dha...@gmail.com on 22 Aug 2008 at 12:39

GoogleCodeExporter commented 9 years ago
OK for shutdown().

The auto-start/shutdown is an excellent idea, but I think it should be an 
opt-in.
Perhaps we can subclass our "one and only" SPRFilter. 
LifecycleSessionPerRequestFilter?

Original comment by robbie.v...@gmail.com on 22 Aug 2008 at 1:05

GoogleCodeExporter commented 9 years ago
Added PersistenceService.shutdown()
Added LifecycleSessionFilter

Original comment by robbie.v...@gmail.com on 23 Aug 2008 at 3:20

GoogleCodeExporter commented 9 years ago

Original comment by robbie.v...@gmail.com on 8 Sep 2008 at 4:53

GoogleCodeExporter commented 9 years ago
LifecycleSessionFilter has been renamed to PersistenceServiceSessionFilter.

Original comment by robbie.v...@gmail.com on 22 Dec 2008 at 2:29

GoogleCodeExporter commented 9 years ago
How about we go with the one filter that does everything. We can leave it 
non-final so people who dont want 
lifecycle can override init() and destroy().

Original comment by dha...@gmail.com on 23 Dec 2008 at 1:16

GoogleCodeExporter commented 9 years ago
See issue #10

Original comment by robbie.v...@gmail.com on 23 Dec 2008 at 5:20