wangscript / warp-persist

Automatically exported from code.google.com/p/warp-persist
0 stars 0 forks source link

Support @Transactional on dynamic accessors #9

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
We could detect @Transactional and support it without breaking compat.

Original issue reported on code.google.com by robbie.v...@gmail.com on 20 Aug 2008 at 11:53

GoogleCodeExporter commented 9 years ago
That's a pretty good idea. Unfortunately it doesn't work with custom matchers.

Is that a bad tradeoff?

Original comment by dha...@gmail.com on 21 Aug 2008 at 8:03

GoogleCodeExporter commented 9 years ago
If we add #8 it will not be an issue, but I understand the concern. The DF
functionality is getting complicated now I added the multiple modules support. 
I'll
document what we have on the wiki to improve our understanding of what the user 
is
going to have to deal with. We might need to give in some elegance for 
consistency.

Original comment by robbie.v...@gmail.com on 21 Aug 2008 at 8:43

GoogleCodeExporter commented 9 years ago

Original comment by robbie.v...@gmail.com on 21 Dec 2008 at 5:40

GoogleCodeExporter commented 9 years ago
r255 has the initial implementation. 

We could actually filter incoming accessors through the TX matchers so we don't
transact finders when we don't have to (according to the tx config). I think 
that is
what people would expect so I'll have a look at that.

Original comment by robbie.v...@gmail.com on 21 Dec 2008 at 10:26

GoogleCodeExporter commented 9 years ago

Original comment by robbie.v...@gmail.com on 21 Dec 2008 at 10:26

GoogleCodeExporter commented 9 years ago
r256 now respects the TX matchers. Not closing because we might want some more 
test
cases.

Original comment by robbie.v...@gmail.com on 21 Dec 2008 at 11:04

GoogleCodeExporter commented 9 years ago

Original comment by robbie.v...@gmail.com on 22 Dec 2008 at 10:40

GoogleCodeExporter commented 9 years ago
Awesome!

Original comment by dha...@gmail.com on 23 Dec 2008 at 1:00