search

wangsix / vmo

Python Modules of Variable Markov Oracle
GNU General Public License v3.0
25 stars 10 forks source link

Direct access to undocumented class attribute 'latent' #7

Closed tbazin closed 9 years ago

tbazin commented 9 years ago

@wangsix Both demo notebooks use direct accesses to VMO.latent. Furthermore, this method is not documented in the class' definition.

Consider creating a method to access this attribute if it is really needed, in order to respect the encapsulation principle.

wangsix commented 9 years ago

@tbazin Thank you so much for the suggestion. I just updated the documentation for the mo.latent attribute and some others.

I have been developing this module by myself so there was no other eyes looking at where could be improved. Great appreciation for your suggestion.

tbazin commented 9 years ago

Pleasure is mine! I'm finally starting to get the hang of what's going on in here, so expect some more issues/commits :smile: