search

wangtingjia / pe

0 stars 0 forks source link

Exception when terminating program #1

Open wangtingjia opened 1 year ago

wangtingjia commented 1 year ago

Exception thrown when terminating program with Ctrl-C

Should just terminate program without exception

image.png

soc-pe-bot commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Lack of CTRL-C handling leads to data loss

Out of habit, users who are accustomed to using other command-line programs may use CTRL-C to exit the currently-running program instead of using the "exit" command. This leads to a NoSuchElementException stack trace being printed onto the screen, and more critically, causes the data saving routines to not be run, thus leading to the loss of whichever data was input during the session. It may be prudent to handle this case in a more graceful manner. This bug has been rated Medium due to the potential for data loss, while recognising that exiting the program in this manner is a deviation from the expected way to exit the program documented in the User Guide.

[original: nus-cs2113-AY2223S1/pe-interim#1023] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

User guide mentions save only works when the user exits properly and dynamic saving is not part of feature due to poor efficiency.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: Having the data saved is different from handling the exception when exiting the program.

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: The Ctrl C function is commonly used by users to exit a program. The error message does not seem to correct user usage. The UG only states do not close the program but it does not seem clear in referring to Ctrl-C

:question: Issue severity

Team chose [severity.Medium] Originally [severity.High]

Reason for disagreement: [replace this with your explanation]