search

wangvisual / expression-search

Expression Search is a Thunderbird addon that add search features like Gmail
https://addons.thunderbird.net/en-US/thunderbird/addon/gmailui/
GNU General Public License v3.0
78 stars 23 forks source link

Incompatible with Thunderbird 68 #80

Open parcelcat opened 5 years ago

parcelcat commented 5 years ago

This extension (as released in the Thunderbird Add-ons site) is incompatible with Thunderbird 68.

The release notes for Thunderbird 68 state:

Add-on support: Add-ons are only supported if add-on authors have adapted them

Thanks for maintaining this extension. I hope all is well.

aleqx commented 4 years ago

I too would switch away from TB if I don't have this functionality (TB has already gotten very sluggish for me as my inbox sizes and email accounts have grown).

A million thanks to @wangvisual for all the efforts and time!

LRN commented 4 years ago

Good news: (FiltaQuilla)[https://addons.thunderbird.net/en-US/thunderbird/addon/filtaquilla/] was updated to support TB 68. This is not quite a replacement for expression search, but it can be used to do some of the same things in a pinch.

dimitrior commented 4 years ago

This add-on is really 80% of the reason I use Thunderbird. I would readily pay a regular fee towards keeping it maintained. I voted on bugzilla - let's keep hoping!

jph108 commented 4 years ago

To the author, Opera Wang - this is a really great Add-on. Are there any circumstances under which you would consider supporting it again, or is this the end?

jph108 commented 4 years ago

I've found a way to restart Thunderbird with just a keypress, and this helps a lot. The extension is called "Just Restart", and there is a TB 68-compatible version at the link below. Download the "just_restart-1.2_TB68-tb.xpi" file. After installing, then when TB starts up each day, you can press Control-Shift-Z to restart it, and Expression Search wil be available.

https://github.com/opto/just_restart_TB68

robin-uk commented 4 years ago

Just want to add my input. Like other comments, expression-search has proved to be SUCH a useful add-on over many years. I accidentally upgraded to TB 68 in 2019 and found that expression-search no longer worked, so I downgraded back to TB 60 as a temporary measure. Now have taken some time to evaluate options and am happy to report that 1.4 rc1 does work with current TB release 68.3.1 (on Mac) PROVIDED the add-on is disabled/re-enabled and then TB is restarted. As others report, this isn't ideal and the search box has got a glitch (two text boxes in one - only left one works), but it is working. I'm making a donation to Opera Wang to help support getting this to a fully supported version.

Bbillyben commented 4 years ago

Hi there, I'm running portable version of thuderbirds, with some other module, win 7 pro 64b.

I have accidently update my TB to 68.4.1 and I do remember now why I don't before.

I've tried v1.4 from wangvisual. I've got some bugs, which may result of interaction with other modules : 1/ disparition of the resize icon of my message window 2/ perpetula loading and no email update

As soon as I deactivate the plugin, everything back as expected...

I will investigate on interaction as soon as I have more time.

biva commented 4 years ago

@wangvisual We understand that you're not able to update the extension. In order to encourage core TB developer to work on it, could we ask you to change the description of your extension in https://addons.thunderbird.net/fr/thunderbird/addon/gmailui/ to ask people to vote for the bugzilla issue. For example, a text like:

"For all interested in updating this addon, please vote in https://bugzilla.mozilla.org/show_bug.cgi?id=538821 (under the 'Details' paragraph) but please don't add any comment to the thread if you don't add further information, it's not useful and could disturb the work of thunderbird developers. Thanks!"

Thank so much in advance!

spenibus commented 4 years ago

Starting with the purgecaches option makes the addon usable.

thunderbird.exe -purgecaches

Furthermore, after setting nglayout.debug.disable_xul_cache to true in the config editor then starting once with purgecaches, it looks like the addon is working normally even when starting without purgecaches on subsequent launches.

It's not a proper fix but it seems to work. Tested on 68.4.1 and 68.6.0.

RalfRoemling commented 4 years ago

@spenibus can confirm -purgecaches working on 68.6.0 but have no entry nglayout.debug.disable_xul_cache

spenibus commented 4 years ago

The pref needs to be added manually as a bool. And set to true, obviously.

nglayout.debug.disable_xul_cache Config Editor

daniel-lo commented 4 years ago

@spenibus

1.4 rc1 fails to install on TB Windows .. it fails compatibility check. How did u get around that?

RalfRoemling commented 4 years ago

@spenibus works. @daniel-lo Weird. I could install from file without check.

spenibus commented 4 years ago

I just tried on a new profile and also got no check, using the file from this comment. There's also extensions.checkCompatibility as a last resort.

daniel-lo commented 4 years ago

thanks for your feedback guys .. not even extensions.checkCompatibility was of help.

about

btw .. neither does: extensions.strictCompatibility

Inserm-CRI-LBI commented 4 years ago

Starting with the purgecaches option makes the addon usable.

thunderbird.exe -purgecaches

Furthermore, after setting nglayout.debug.disable_xul_cache to true in the config editor then starting once with purgecaches, it looks like the addon is working normally even when starting without purgecaches on subsequent launches.

It's not a proper fix but it seems to work. Tested on 68.4.1 and 68.6.0.

Can confirm 68.6.0. Beautiful ! Life Saver ! Infinite thanks !

RalfRoemling commented 4 years ago

@spenibus Ups... forgot... Big Thanks also from me! :-)

biva commented 4 years ago

Furthermore, after setting nglayout.debug.disable_xul_cache to true in the config editor then starting once with purgecaches, it looks like the addon is working normally even when starting without purgecaches on subsequent launches.

Indeed, I confirm that it works (TB 68.6 64 bits). In addition, I removed nglayout.debug.disable_xul_cache afterwards and it keeps working without starting with -purgecaches

@spenibus Is it preferable to keep it set it to true? I read in your link: "There is (unsurprisingly) a performance hit associated with setting this preference to true." Alternatively, what would be the problem to always start with thunderbird.exe -purgecaches instead of setting nglayout.debug.disable_xul_cache to true?

fp66 commented 4 years ago

Thanks a lot for the workaround!

However, I still see the search form twice:

grafik

Don't you?!

spenibus commented 4 years ago

@biva Without the pref, it would eventually stop working for me. As to whether use the flag or the pref, it probably doesn't make much of a visible difference.

@fp66 See ticket #85 for a css fix.

dimitrior commented 4 years ago

Starting with the purgecaches option makes the addon usable.

thunderbird.exe -purgecaches

Furthermore, after setting nglayout.debug.disable_xul_cache to true in the config editor then starting once with purgecaches, it looks like the addon is working normally even when starting without purgecaches on subsequent launches.

It's not a proper fix but it seems to work. Tested on 68.4.1 and 68.6.0.

THANK YOU. Order restored!