wangvisual / ldapinfo

Show contact photo and other info from Local Dir, Addressbook, LDAP, Facebook, LinkedIn, Flickr, Gravatar etc for Thunderbird
https://addons.mozilla.org/en-US/thunderbird/addon/ldapinfoshow/
GNU General Public License v3.0
22 stars 5 forks source link

incompatible with Thunderbird 68.0 #41

Open linkp opened 5 years ago

linkp commented 5 years ago

Following an update to Thunderbird 68.0 Awesome ldapInfoShow is now disabled and marked as incompatible.

MozillaThunderbird Version 68.0-lp151.6.1 x86_64 from obs://build.opensuse.org/mozilla Awesome ldapInfoShow Version 1.2

jmfernandez commented 5 years ago

The same here, but using Gentoo Linux. Thunderbird was upgraded to 68.1.0 , and Awesome ldapInfoShow was disabled as it does not support the new MailExtensions APIs

jmfernandez commented 4 years ago

After having a look at the latest commits, I found one referring to TB 68, which led me to think @wangvisual had the extension almost ready for Thunderbird 68.0.

I have adapted the manifest.json and release.sh from the sibling project https://github.com/wangvisual/autoarchive and generated an xpi file, in order to know whether it would work. The configuration dialog is currently broken (black background and no correct values in the fields). The LDAP images fetch logic seems to work, as well as the underlying logic which shows the contact photos on composition, address book and e-mail reading.

As it is a trivial change and I have developed nothing, instead of forking the project I have just included the tar.gz file ldapinfo-81b83d50de4f32a141ba9c6a02a242a0f51b81c7.tar.gz , which contains a pre-generated ldapinfo-1.3beta-tb.xpi file in src subdir (in case someone is as desperate as me to keep this awesome extension in her/his updated thunderbird installation).

CharlesDelorme commented 4 years ago

Has anyone any update on an official release ?

defacto64 commented 4 years ago

Thank you so much @jmfernandez ! I was badly missing it. It would indeed be great if someone involved in this project found the time to prepare a fully functional and official 1.3 release....

msebald commented 4 years ago

@jmfernandez Thank you for providing the beta for TB 68. Unfortunally I cannot install it in TB 68.10.0 - did something change since the initial release of TB 68? Anyway, do you have a version which also works with TB 68.10.0? Or is there any light at the end of the tunnel for an official release? ;-)

gruniversal commented 3 years ago

I took the version of @jmfernandez and updated the manifest.json to work with TB 68.* which works for my needs: ldapinfo-1.3beta-tb.xpi.tar.gz

{
  "applications": {
    "gecko": {
      ...
      "strict_max_version": "68.99"
    }
  },
...
AlexUkr73 commented 3 years ago

Good news, I have ported this extension to >=TB78 using Expreriments API:

Good luck!

rgpublic commented 3 years ago

Great, but wouldn't it make more sense to create a pull request?

AlexUkr73 commented 3 years ago

rgpublic - I don't know nothing about this (pull request). I don't have enough skills in programming, and was forced to make my favorite addon working and have read a tons of manuals how to do it. I found this page while was searching for solutions with TB68 some time ago and @jmfernandez helped me a lot. So, I played around with new TB78 trying to make it working and just shared this here.

rgpublic commented 3 years ago

@AlexUkr73 : Ah, sure, understood. Thanks for sharing it anyway - certainly useful.

msebald commented 3 years ago

Good luck!

Cool, it works for me. At least when having a brief look for 1 minute just now. Keep you posted. Thank you very much!

Is it possible to merge this in here? :-)

AlexUkr73 commented 3 years ago

@msebald : Great. Let's continue to discuss TB78 in issue# 43 thread to avoid confusing people who search for solutions for TB68 here. As far as I understood - they are already solved by @gruniversal