search

wangweitl81 / googletest

Automatically exported from code.google.com/p/googletest
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

wrong documentation and inadequate tests for parameter generator evaluation #262

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Einar Rune Haugnes reports that in gtest-param-test.h we say that a
parameter generator is evaluated in RUN_ALL_TESTS().  In fact it is
evaluated in InitGoogleTest().

I checked the code and think it's doing the intended thing: by generating
all parameterized tests in InitGoogleTest(), we give the user a chance to
iterate through all the tests using the test reflection API before calling
(or skipping) RUN_ALL_TESTS().  For example, someone may use that
information to build a list of tests and show them in a GUI and let the
user decide which tests to run, or whether to run the tests at all.

We should fix the comment and wiki documentation to say that the parameter
generator is evaluated in InitGoogleTest() instead of RUN_ALL_TESTS().

We should also update/add tests to verify this is indeed the case.  Our
current tests only verify that the generator is evaluated in main(), which
isn't accurate enough.

Original issue reported on code.google.com by w...@google.com on 16 Mar 2010 at 3:02

GoogleCodeExporter commented 9 years ago 
Fixed by Vlad.

Original comment by w...@google.com on 23 Mar 2010 at 7:26