wangyao5 / achartengine

Automatically exported from code.google.com/p/achartengine
0 stars 0 forks source link

Some new features #271

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I attach a patch with this features:
- A improvement of fill under line. Added 3 options to fill outside a line 
(integral, bellow & above). 
- Added fill gradient.
- Minors javadoc fixes.
- Added point stroke width.
- Added minimum distance between lables.
- Added maximum level of zoom.

I worked in this git repository: https://github.com/InQBarna/AChartEngine

I refactored all the code to use achartengine like an android library project. 
I remove the pom.xml file because I don't know how to use Maven.

Original issue reported on code.google.com by braisga...@gmail.com on 7 Feb 2013 at 5:50

Attachments:

GoogleCodeExporter commented 9 years ago
This patch has no chance of being included.
* It is huge, I am not going to add code that is hard to understand. Please 
post small patches, that add one single feature.
* AChartEngine doesn't need to be refactored to be used as a library project.
* Don't remove maven just because you don't understand it. Tens of users have 
asked for it.

Original comment by dandrome...@gmail.com on 7 Feb 2013 at 6:38

GoogleCodeExporter commented 9 years ago
* Ok, I will try to make smaller patches. The attached patch have:
- A improvement of fill under line. Added 3 options to fill outside a line 
(integral, bellow & above).
- A minor javadoc fix.
* Yes it doesn't need but it avoid VerifyError exceptions and I'm more 
confortable with this structure. If you doesn't like it, no problem, my patches 
don't break your architecture.

Original comment by braisga...@gmail.com on 7 Feb 2013 at 7:21

Attachments:

GoogleCodeExporter commented 9 years ago
Awesome contribution. I used your work for the issue #52, as well.
Thanks!

Original comment by dandrome...@gmail.com on 8 Feb 2013 at 11:33