search

wangyu- / udp2raw

A Tunnel which Turns UDP Traffic into Encrypted UDP/FakeTCP/ICMP Traffic by using Raw Socket,helps you Bypass UDP FireWalls(or Unstable UDP Environment)
MIT License
7.28k stars 1.17k forks source link

Redundant Condition in Cipher Mode Check #525

Open XiaoLey opened 6 months ago

XiaoLey commented 6 months ago

Description

It has been observed that there are two lines of code where the condition check for the cipher mode appears to be redundant. Specifically, both instances check for the same condition twice within a single statement.

image

Code Location

The redundant condition appears in two different locations:

Link to code location 1

Link to code location 2

Possible Typo?

It might be a typo that the second condition was intended to check another cipher mode, potentially cipher_aes128cfb. It's worth verifying whether this was the intended logic.

Suggested Action

It would be advisable to review these conditions and correct them if one of them should indeed be cipher_aes128cfb, or if another cipher mode was intended to be checked.

wangyu- commented 6 months ago

Hi this is a bug, if --fix-gro is enabled for cipher_aes128cfb the 16bit gro header is by mistake left unencrpyted.

I will make a fix, hopefully next weekend.

Thanks for reporting.