wangyu5 / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

dependencies inside conditionals inside link_settings fail to have their paths relativized correctly or #target appended to them. #179

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Put a dependencies section inside a conditional inside a link_settings 
(instead of sibling to link_settings)

What is the expected output? What do you see instead?
Expect: gyp complains about dependencies being inside link_settings, because 
naive expectation is that relative paths are interpreted relative to .gyp file, 
and dependencies don't need to end with #target.
Actual: gyp silently accepts dependencies there, with relative paths  
interepreted relative to the directory from which gyp was run, and dependencies 
needing to end in #target to work.

What version of the product are you using? On what operating system?
gyp_chromium on glucid.

Please provide any additional information below.
See concrete example in diff between patchset 2 and 3 of 
http://codereview.chromium.org/6469064/ (patchset 3 fixed the bug present in 
patchset 2)

Original issue reported on code.google.com by fischman@chromium.org on 23 Feb 2011 at 10:43