wangyu5 / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

Squelch warnings about gyp byproducts AdditionalDependencies_excluded and IgnoreDefaultLibraryNames_excluded #180

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Add the following to a gyp file:
           'msvs_settings': {
             'VCLinkerTool': {
               'IgnoreDefaultLibraryNames!': ['libcmtd.lib', 'libcmt.lib'],
               'AdditionalDependencies!': [
                 '<(SHARED_INTERMEDIATE_DIR)/allocator/libcmt.lib'
               ],
             },
           },
2. Run gyp

What is the expected output? What do you see instead?

Should not produce warnings. Instead you get:

Warning: unrecognized setting VCLinkerTool/AdditionalDependencies_excluded
Warning: unrecognized setting VCLinkerTool/IgnoreDefaultLibraryNames_excluded

What version of the product are you using? On what operating system?

Windows/Cygwin revision 874 of MSVSSettings.py

Please provide any additional information below.

Trivial fix:

$ svn diff
Index: pylib/gyp/MSVSSettings.py
===================================================================
--- pylib/gyp/MSVSSettings.py   (revision 874)
+++ pylib/gyp/MSVSSettings.py   (working copy)
@@ -769,7 +769,9 @@
 _MSVSOnly(_link, 'OptimizeForWindows98', _newly_boolean)
 _MSVSOnly(_link, 'UseUnicodeResponseFiles', _boolean)
 # TODO(jeanluc) I don't think these are genuine settings but byproducts of Gyp.
+_MSVSOnly(_link, 'AdditionalDependencies_excluded', _folder_list)
 _MSVSOnly(_link, 'AdditionalLibraryDirectories_excluded', _folder_list)
+_MSVSOnly(_link, 'IgnoreDefaultLibraryNames_excluded', _folder_list)

 # MSBuild options not found in MSVS.
 _MSBuildOnly(_link, 'BuildingInIDE', _boolean)

Original issue reported on code.google.com by jaysoff...@gmail.com on 25 Feb 2011 at 6:45

GoogleCodeExporter commented 9 years ago
Updated:

Index: MSVSSettings.py
===================================================================
--- MSVSSettings.py (revision 931)
+++ MSVSSettings.py (working copy)
@@ -822,7 +822,10 @@
 _MSVSOnly(_link, 'OptimizeForWindows98', _newly_boolean)
 _MSVSOnly(_link, 'UseUnicodeResponseFiles', _boolean)
 # TODO(jeanluc) I don't think these are genuine settings but byproducts of Gyp.
+_MSVSOnly(_link, 'AdditionalDependencies_excluded', _folder_list)
+_MSVSOnly(_link, 'AdditionalOptions_excluded', _folder_list)
 _MSVSOnly(_link, 'AdditionalLibraryDirectories_excluded', _folder_list)
+_MSVSOnly(_link, 'IgnoreDefaultLibraryNames_excluded', _folder_list)

 # MSBuild options not found in MSVS.
 _MSBuildOnly(_link, 'BuildingInIDE', _boolean)

Original comment by jaysoff...@gmail.com on 18 Jul 2011 at 10:18