search

wangyu5 / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

GYP make generator fails on FreeBSD (flock and flavor issue) #251

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Makefiles produced by gyp currently fail on FreeBSD.

I have included a patch which fixes two issues:

1. Map 'freebsd9' and 'freebsd10' to freebsd flavor
2. Fix flock reference in Makefile - currently it's referencing 'flock_command' 
which always points to  'flock' instead of a variable which has been updated 
with a platform specific value

Original issue reported on code.google.com by tomaz.muraus on 15 Feb 2012 at 6:22

Attachments:

GoogleCodeExporter commented 9 years ago 
You need to upload your patch to https://chromiumcodereview.appspot.com/ to get 
it reviewd, otherwise it's just going to sit here.

Original comment by thestig@chromium.org on 9 Mar 2012 at 8:12

GoogleCodeExporter commented 9 years ago 
Is this planned to be accepted? Since g++ no longer exists, this is breaking 
builds of node-sqlite3 (which use node-gyp) on new freebsd systems 
(https://github.com/mapbox/node-sqlite3/issues/250#issuecomment-34278381), 
which in turn is preventing applications like Ghost from working on Freebsd. 
Also #249 looks like a duplicate of this.

Original comment by d...@mapbox.com on 6 Feb 2014 at 9:06

GoogleCodeExporter commented 9 years ago 
bump

Original comment by d...@mapbox.com on 25 Feb 2014 at 11:47

GoogleCodeExporter commented 9 years ago 
Any progress on this?

Original comment by d...@mapbox.com on 3 Apr 2014 at 8:21

GoogleCodeExporter commented 9 years ago 
Did you upload your patch for review, per comment 1?

Original comment by thestig@chromium.org on 3 Apr 2014 at 8:29

GoogleCodeExporter commented 9 years ago 
I'm having this issue too. Dunno if the original guy ever submitted the patch 
for review. node-sqlite3 pointed me here.

Original comment by Eris...@gmail.com on 26 Sep 2014 at 5:11

GoogleCodeExporter commented 9 years ago 
I think this affects any C++ Node module using node-gyp. I ran into this issue 
trying to compile node-zeromq on FreeBSD 10.

Original comment by si...@nostalgeek.com on 29 Sep 2014 at 11:32

GoogleCodeExporter commented 9 years ago 
Hi, I have same issues on freebsd, this is actually the only thing which stops 
me to use node on freebsd.

Original comment by dmitry.chirkin on 14 Feb 2015 at 10:05