-G msvs_version=2008 not work

I had a similar problem, using gyp from breakpad r639.

I have both visual studio 2005 and visual studio 2008 installed, but I wanted 
to create project files for visual studio 2005.

I used the following commandline, which failed with the following error:
> gyp ..\..\client\windows\breakpad_client.gyp -G msvs_version=2005

Traceback (most recent call last):
  File "C:\dev\trunk\third_party\breakpad\src\tools\gyp\/gyp", line 18, in <module>
    sys.exit(gyp.main(sys.argv[1:]))
  File "C:\dev\trunk\third_party\breakpad\src\tools\gyp\pylib\gyp\__init__.py", line 423, in main
    params, options.check)
  File "C:\dev\trunk\third_party\breakpad\src\tools\gyp\pylib\gyp\__init__.py", line 61, in Load
    generator.CalculateVariables(default_variables, params)
  File "C:\dev\trunk\third_party\breakpad\src\tools\gyp\pylib\gyp\generator\msvs.py", line 1014, in CalculateVariables
    default_variables['MSVS_VERSION'] = msvs_version.ShortName()
AttributeError: 'NoneType' object has no attribute 'ShortName'

I fixed this problem by patching breakpad\src\tools\gyp\pylib\gyp\MSVSVersion.py

def _CreateVersion(name):
   versions = {
   ...
   ...
   }
-  return versions.get(name)
+  return versions.get(str(name))

Original comment by avia...@gmail.com on 11 Aug 2010 at 2:42

wangyu5 / gyp

-G msvs_version=2008 not work #97