DroplistFilterEditor doesn't show all options with auto filtering and sorting disabled

[GoogleCodeExporter]

Typical usage for this filter editor is to use it with a small number of
items, which it then introspects for all of the distinct values available.
 Problems occur, however, when you set the total rows on the limit yourself
and only pass in a subset of all of the items.  If not all of the possible
values are included in the subset, they are not included in the filter
editor's droplist.

If this is an enumeration (or the results of lookup table or something), I
know the possible values, so it would be nice if I could set them myself.

This is actually really easy to accomplish by overriding getOptions(), but
I think that built-in support for a method like setOptions(String[][])
would be prudent (like DefaultTableModel for JTable).

If you think this is a good idea, I can submit the code and try to sneak it
in before the next release.

Original issue reported on code.google.com by bgo...@e1b.org on 17 Mar 2009 at 12:52

[GoogleCodeExporter]

You and one other developer are totally driving this next release so feel free 
to
submit that patch! The only thing I will do is delay the release so that the 
code
sits on the trunk for a few days. That gives other developers a chance to try 
out the
code and also more time to ensure that things work as expected.

Original comment by jeff.johnston.mn@gmail.com on 17 Mar 2009 at 2:05

• Changed state: Accepted

[GoogleCodeExporter]

Just checking on your progress...I'm thinking that we should just do another 
release
this week and then put this change out after that. What do you think?

Original comment by jeff.johnston.mn@gmail.com on 30 Mar 2009 at 7:16

[GoogleCodeExporter]

Actually just finished this patch a few minutes ago and I was testing it out.  I
think that the changes are fairly straightforward, but please let me know if 
you have
any questions.

Original comment by bgo...@e1b.org on 30 Mar 2009 at 7:49

Attachments:

• patch.txt

[GoogleCodeExporter]

Great! I'll take a look at this in the next couple days.

Original comment by jeff.johnston.mn@gmail.com on 31 Mar 2009 at 2:43

[GoogleCodeExporter]

I have the patch applied and on the trunk now. Nice work! I did some super small
tweaks. One was renaming options in the methods to opts so that the value was 
not
overriding the global variable. I try to avoid that nowadays although I'm sure 
you'll
see code that is still doing it...I just try not to. I also combined one of the
bulletproof checks.

In addition I did one small tweak to the jquery.jmes.js file in that I took out 
the
encoding for the setting of the hidden input filter fields. The browser will do 
that
automatically and the encoding was messing up some values.

Let me know if any of my small tweaks broke anything. Other than that I think 
we are
ready for another release!

Original comment by jeff.johnston.mn@gmail.com on 1 Apr 2009 at 6:54

[GoogleCodeExporter]

Original comment by jeff.johnston.mn@gmail.com on 5 Apr 2009 at 1:25

• Changed state: Done