search

wankdanker / node-discover

Automatic and decentralized discovery and monitoring of nodejs instances with built in support for a variable number of master processes, service advertising and channel messaging.
229 stars 59 forks source link

Couldn't run ddnode.js #1

Closed srb6556 closed 11 years ago

srb6556 commented 11 years ago

I've tried to run ddnode-test.js, but I've found few errors in there, from line 47 [client.id]. Can anyone help me with this issue.

Thanks in advance.

wankdanker commented 11 years ago

Hey @prakas,

What OS are you and and what version of node-discover? Maybe try using dnode v0.8.2 npm install dnode@0.8.2. That is the version I used in my tests.

Dan

srb6556 commented 11 years ago

Yes itz working, perfect. Thank you. :)

skeggse commented 11 years ago

Interestingly my references to pull request skeggse/node-discovery#1 actually referenced #1.

Anyway, I don't know that this issue is resolved. The purpose of an example is to demonstrate usage in a situation, and while this example may have the correct usage for node-discover, it does not have the correct usage for dnode.

I may end up attempting to fix it, but I'll have to figure out how to translate the code to work with the far newer dnode.

wankdanker commented 11 years ago

I'll have to try to get these merged into my fork...

The last time I used dnode was when I wrote that example, so, I haven't kept up with it. What I would love to see is moving the examples into their own repositories/modules so that they can live on their own. Then we can just point to those modules as examples from the readme file.

wankdanker commented 11 years ago

BTW, @skeggse, I see that you have been making some serious progress. Let me know if you want anything merged and I'll take care of it.

skeggse commented 11 years ago

I'm making some design changes, once it stabilizes and we're in production I'll have you take a look and see if you want to merge. Thanks for the tips!