search

wankdanker / node-discover

Automatic and decentralized discovery and monitoring of nodejs instances with built in support for a variable number of master processes, service advertising and channel messaging.
229 stars 59 forks source link

Incoming data not fully exposed #9

Closed bigmonkeyboy closed 9 years ago

bigmonkeyboy commented 9 years ago

When a data packet arrives at the underlying network.js (line 56) if gets emitted along with the complete object and the rinfo.

In the join function in the layer above (discover.js) when that get's handled ( lines 285-7 ) only the data part gets passed on... Is there any good reason not to extend that function to pass them all on ? (or at least the object ?

    self.broadcast.on(channel, function (data, obj, rinfo) {
        self.emit(channel, data, obj, rinfo);
    });

(Though in fact all I am after is the obj.hostName but hey.)