Updates for Node version 4.x - Githubissues

wankdanker / node-odbc

ODBC bindings for node

MIT License

174 stars 79 forks source link

Updates for Node version 4.x #23

Closed dfbaskin closed 9 years ago

dfbaskin commented 9 years ago

There is still more to do with the source, so I don't expect this to be merged, but I wanted to get the conversation started.

The things that are still remaining are:

Check compilation for other preprocessor definitions (DEBUG, UNICODE, dynodbc)
Verify that it builds on OSX and Linux (I performed the update on a Windows machine)
Verify the tests

Right now, it builds correctly with the default settings, but most of the tests are failing, but I don't have the all of the test databases and ODBC connections configured correctly yet.

wankdanker commented 9 years ago

This looks GREAT!

I made the changes I mentioned above and it compiled and most tests succeeded on my Linux box with v4.0.0. Even though NAN is supposed to support v0.8, 0.10, 0.12, none of those compile for me. Just a few errors thrown though. Should be able to figure it out.

wankdanker commented 9 years ago

Here are some fixes I made that were working but now they are not: b15cbea9f787892adb761f1d6eb75d5b487a56c0. Have to run, but wanted to get these out there.

wankdanker commented 9 years ago

Correction, this branch works with 0.12.7 and 4.0.0: https://github.com/wankdanker/node-odbc/tree/fix-for-node-v0.12.7

wankdanker commented 9 years ago

This branch contains the remaining fixes for node 0.10.40 and 0.8.28: https://github.com/wankdanker/node-odbc/tree/fix-for-node-v0.10.40

dfbaskin commented 9 years ago

Thanks! I'll integrate those changes into this pull request. What should we change the version number of the package to? 1.1.9? 1.2.0? 2.0.0?

wankdanker commented 9 years ago

I'll take care of the version bump. It's going to be 1.2.0 though. Working on merging and releasing now.

dfbaskin commented 9 years ago

Great, thanks!

wankdanker commented 9 years ago

Published odbc@1.2.0 to npm.