wannesm / dtaidistance

Time series distances: Dynamic Time Warping (fast DTW implementation in C)
Other
1.08k stars 184 forks source link

conda-forge osx-arm64 build #190

Closed kbrownlees closed 1 year ago

kbrownlees commented 1 year ago

Apologies if this is the wrong place to request this. But it would be great to understand what would be involved in adding a osx-arm64 build to conda-forge?

Many thanks for the great package!

wannesm commented 1 year ago

The main reason why it is not there might be a lack of knowledge on our end. @m-rossi has been generously keeping the Conda version up to date. If we can find some time, we can investigate whether it is simply adding the architecture to the script or more is involved (e.g. for github actions, arm64 is not yet available and we need to compile locally).

For the package itself, it is compatbile with osx-arm64 as this is one of the architectures we use ourselves. Thus if you have the xcode tools (and openmp) installed, it should work from source. Or via pypi you can also download a precompiled version for Python 3.10 and macos 12 (we can add other python versions if useful).

m-rossi commented 1 year ago

It can be as simple as adding the architecture. I need to check if all requirements are already available on osx-arm64

m-rossi commented 1 year ago

Looks good, will try to add an Apple Silicon builds

m-rossi commented 1 year ago

@kbrownlees builds for osx-arm64 should be available now.

wannesm commented 1 year ago

Wow, this was fast. Thanks @m-rossi !

kbrownlees commented 1 year ago

Amazing! Thank you for the incredible turn around @m-rossi & @wannesm!

I was able to successfully install it from conda-forge on my M1 mac & https://anaconda.org/conda-forge/dtaidistance confirms it is now available.