search

wannier-developers / wannier90

Official repository of the Wannier90 code
http://www.wannier.org
GNU General Public License v2.0
232 stars 137 forks source link

Parallelization of Wannier functions plotting disappeared in the latest develop branch #503

Open npaulish opened 2 months ago

npaulish commented 2 months ago

As I also mentioned in the email to @JeromeCCP9, even though #370 was merged, wannier_plot is not parallelized in the latest develop branch. Maybe there could be also other PRs that disappeared after merging the library mode? FYI @jiang-yuha0 @qiaojunfeng @giovannipizzi

PeterKraus commented 1 month ago

I think #332 could be another victim, see https://github.com/wannier-developers/wannier90/pull/332#issuecomment-2162885492

JeromeCCP9 commented 1 month ago

Hi Peter! Thank you for flagging this up, I will track it down...

giovannipizzi commented 1 month ago

Thanks Peter! @JeromeCCP9 I now have a strong feeling that quite a few PRs might have been discarded. We'll have to check several of them, probably in a time range, I imagine from when you started working in the code onwards. It might be that most of them are actually lost, as you worked on top of earlier versions?

giovannipizzi commented 1 month ago

There are I think 34 merged PRs between 3.1 and the merge of the library interface. I would check all. Hopefully about a half should be not on the code (tests, docs,...) so those should be OK. So hopefully there are not that many that could have been lost. But the others might require a bit of work to re implement in the new code structure

JeromeCCP9 commented 1 month ago

yes, this is true. The corresponding commits exists in the history, but the changes are exactly undone in the current state of develop. I think this means a merge has gone wrong, which is a small nightmare. I investigate more.

JeromeCCP9 commented 1 month ago

yap, I caused this in merge 6f7859ef8 ; merging the use of types, Feb 2021. Unfortunately it is not a merge commit, so I must have rebased incorrectly. From the date, I can see that this will indeed affect a couple of other PRs.

I'm so sorry about this! I work to resolve it.