codepathreview
commented
9 years ago :+1: Nice work! The point of this homework was to explore a simple example of a full MVC application with a RESTful API. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:
- As a reminder, there are two great style guides in the Swift community like Ray Wenderlich's Swift Style Guide and Github's Swift Style Guide
- You can remove generated Xcode functions, if not used (e.g. https://github.com/wansteve/Rotten-Tomatoes/blob/98d49b66cf1f528805c8bed2f9045cffb2919921/Rotten%20Tomatoes/MoviesViewController.swift#L172-L175)
- You should always try to minimize the number of properties and methods that are public or internal (access is internal by default). Make the access private if the property or function doesn't need to be accessed outside the class.
- In future homework, we will cover how to implement models that can deserialize from an NSDictionary. SwiftyJSON is a useful project for making it easier to deserialize the JSON response.
- Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
- Nice work loading the images asynchronously.
- Nice work setting up the proper modes for the images so that they are not stretched.
- Nice work implementing the error message on network failure.
In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.
Feel free to reach out, if you have any questions! I'd be glad to help! :smile:
- @jasdev
My week 1 assignment is complete. Thanks! /cc @codepath