search

wantedly / step-pretty-slack-notify

Posts wercker build/deploy status to a Slack channel
MIT License
88 stars 34 forks source link

Use empty string for default value of environment variables #26

Closed deeeki closed 8 years ago

deeeki commented 8 years ago

When using docker stack, it seems Wercker always sets empty string regardless of yaml configuration.

The build step log (It should be aborted with the message Please specify ...):

export WERCKER_STEP_ROOT="/pipeline/pretty-slack-notify-b1281e11-e39c-4f83-b1f0-045384a495db"
export WERCKER_STEP_ID="pretty-slack-notify-b1281e11-e39c-4f83-b1f0-045384a495db"
export WERCKER_STEP_OWNER="wantedly"
export WERCKER_STEP_NAME="pretty-slack-notify"
export WERCKER_REPORT_NUMBERS_FILE="/report/pretty-slack-notify-b1281e11-e39c-4f83-b1f0-045384a495db/numbers.ini"
export WERCKER_REPORT_MESSAGE_FILE="/report/pretty-slack-notify-b1281e11-e39c-4f83-b1f0-045384a495db/message.txt"
export WERCKER_REPORT_ARTIFACTS_DIR="/report/pretty-slack-notify-b1281e11-e39c-4f83-b1f0-045384a495db/artifacts"
export WERCKER_PRETTY_SLACK_NOTIFY_USERNAME=""
export WERCKER_PRETTY_SLACK_NOTIFY_BRANCHES=""
export WERCKER_PRETTY_SLACK_NOTIFY_NOTIFY_ON=""
export WERCKER_PRETTY_SLACK_NOTIFY_WEBHOOK_URL=""
export WERCKER_PRETTY_SLACK_NOTIFY_CHANNEL=""
source "/pipeline/pretty-slack-notify-b1281e11-e39c-4f83-b1f0-045384a495db/run.sh" < /dev/null
Ruby Version: ruby 2.2.3p173 (2015-08-18 revision 51636) [x86_64-linux]
Ruby Path: /usr/local/bin/ruby
Install User: root

Installing slack-notifier...
Successfully installed slack-notifier-1.2.1
1 gem installed
/usr/local/bundle/gems/slack-notifier-1.2.1/lib/slack-notifier/default_http_client.rb:27:in `request_obj': undefined method `request_uri' for #<URI::Generic > (NoMethodError)
    from /usr/local/bundle/gems/slack-notifier-1.2.1/lib/slack-notifier/default_http_client.rb:21:in `call'
    from /usr/local/bundle/gems/slack-notifier-1.2.1/lib/slack-notifier/default_http_client.rb:8:in `post'
    from /usr/local/bundle/gems/slack-notifier-1.2.1/lib/slack-notifier.rb:26:in `ping'
    from /pipeline/pretty-slack-notify-b1281e11-e39c-4f83-b1f0-045384a495db/run.rb:65:in `<main>'
dtan4 commented 8 years ago

LGTM :+1: Thanks :exclamation:

dtan4 commented 8 years ago

Released as v0.2.14 :rocket:

deeeki commented 8 years ago

Thanks for the quick response! :smiley: