wantedly / step-pretty-slack-notify

Posts wercker build/deploy status to a Slack channel
MIT License
88 stars 34 forks source link

Username does not default to Wercker #40

Closed drewfranklin closed 7 years ago

drewfranklin commented 7 years ago

In the slack notification the username does not default to Wercker. It looks like environment variable WERCKER_PRETTY_SLACK_NOTIFY_USERNAME is not being defined in script/run, but I am not exactly sure if that is the issue

screen shot 2016-11-29 at 2 26 32 pm

spesnova commented 7 years ago

@drewfranklin Thank you for reporting. Could you show me your wercker.yml ? I might be able to help you.

drewfranklin commented 7 years ago

For sure box: zdfs/docker-suit build: steps:

Sorry about the formatting but using the code markup makes it one line

spesnova commented 7 years ago

@drewfranklin Thank you for sharing it to me.

At first, you might be able to work around by specifying username option like this:

        - wantedly/pretty-slack-notify:
            webhook_url: $SLACK_WEBHOOK_URL
            channel: suit
            username: Wercker

To find the root cause, could you show me "wantedly/pretty-slack-notify" step's log on wercker?

drewfranklin commented 7 years ago

Awesome thanks for the quick fix Here is my log screen shot 2016-12-01 at 10 32 51 am

spesnova commented 7 years ago

@drewfranklin Thanks! I could find the root cause from your log ❗️ This bug will be fixed in next release 😃
So please use username option to workaround until next version released.

dtan4 commented 7 years ago

@drewfranklin step-pretty-slack-notify v0.3.4 including the fix of this issue was just released. Please try it.

drewfranklin commented 7 years ago

Yep it worked thanks so much everyone!