Closed outrunthewolf closed 9 years ago
Could you possibly add in a build status or some kind of CI step for pull requests
Hi, please let me know example usage about this to understand your request.
And it looks you are passing $SLACK_TOKEN
to webhook_url
like this:
build:
after-steps:
- wantedly/pretty-slack-notify:
webhook_url: $SLACK_TOKEN
I think this cause this wercker step fail. You have to pass webhook url instead of token since Slack changed webhook style. Here is sample screenshot in "incoming webhook" settng page to get webhook url.
Thank you you're a super star
I just ran into this. Can you print a nicer message about this please?
I just ran into this. Can you print a nicer message about this please?
You mean pretty-slack-notify should print some warning message when user uses slack token or webhook_url is missing? Yep, it make sense.
I'll update this later, thanks!
I'll update this later, thanks!
Oh, I forgot that I already print a message if webhook_url is missing.
@ptarjan Can you give me your error message about the failed step.
Hi, Could you possibly add in a build status or some kind of CI step for pull requests. I ask because our build steps fail if this box fails.
I'm really grateful for your work though, so thanks.