search

wantguns / bin

highly opinionated, minimal pastebin
https://basedbin.fly.dev
GNU Lesser General Public License v3.0
213 stars 20 forks source link

Redirect on invalid UTF-8 in /p/ #1

Closed NoraCodes closed 2 years ago

NoraCodes commented 2 years ago

Previously, uploading a paste with invalid UTF-8 and then viewing it with the pretty URL would cause a panic. With this change, it simply redirects to the raw URL.

wantguns commented 2 years ago

Thanks for the input ! Could you please ammend the latest commit after you've run cargo fmt on the project ? I should have added a PR template :')

NoraCodes commented 2 years ago

Yep, will do - sorry about that :sweat_smile:

wantguns commented 2 years ago

Now Clippy is complaining :')

After that, there will be another check in the pipeline which just checks whether the project can be compiled, and cross-compiled w/o any errors.

Please take a look at this, I am gonna make a PR template -- https://github.com/WantGuns/bin/blob/ea144a1024e6e28516a6d0a02bc7dba1e8110e25/.github/workflows/buildci.yml#L12-L16

wantguns commented 2 years ago

Thanks