wanze / SeoMaestro

🧙‍♂️A ProcessWire module helping you to manage SEO related tasks like a boss.
MIT License
34 stars 9 forks source link

Decode Value from database to prevent double enconding of umlauts #16

Closed tiefenb closed 4 years ago

wanze commented 4 years ago

Hi @tiefenb,

Thanks for the pull request. I would like to introduce test cases to make sure that everything also works for other languages before merging this. From my understanding, $sanitizer::entities1 should prevent double encoding issues, but this might not work correctly with the introduced ENT_XML1 flag. 🙈

We should add a test explicitly covering the following cases:

As everything worked fine before I added support to not encode german umlaut characters (see https://github.com/wanze/SeoMaestro/commit/057d8119f37f21bfbf8f4b3aad9e2447b4c90596), I'm thinking of simply revert the change introducing the ENT_XML1 flag and then manually replace encoded german umlauts.

Cheers

jnessier commented 4 years ago

Any updates in here?

wanze commented 4 years ago

Thanks @tiefenb, finally found some time to extend the tests and merge this. New release coming soon.