search

wanze / SeoMaestro

🧙‍♂️A ProcessWire module helping you to manage SEO related tasks like a boss.
MIT License
34 stars 9 forks source link

Fallback to default language if value is empty #27

Closed tiefenb closed 3 years ago

tiefenb commented 3 years ago

https://processwire.com/talk/topic/20817-seomaestro/page/10/?tab=comments#comment-206813

wanze commented 3 years ago

Hi @tiefenb

Thanks!

If we consider the empty string "" the same as null, it won't be possible to actually have empty strings as values. I am not sure if there is a use case for empty values though. I am so disconnected from this topic at the moment, it's hard to say if we would introduce a BC break with this change, because it affects the rendering of meta data. What do you think? Could you give an example of a value that is/was saved as "" in your case?

Cheers

tiefenb commented 3 years ago

Hi @wanze,

FieldtypeTextLanguage/FieldtypeTextareaLanguage fields return an empty string if the value of the current language is not filled. In the field settings you can choose if the field remain blank in the frontend or if the default language should be inherited.

I don't know if there is a use case where some want to have default language value filled but some other language blank values in "SEO" fields.

wanze commented 3 years ago

Thanks!