wanze / SeoMaestro

🧙‍♂️A ProcessWire module helping you to manage SEO related tasks like a boss.
MIT License
34 stars 9 forks source link

Don't allow autojoin FieldtypeSeoMaestro #31

Closed tiefenb closed 3 years ago

tiefenb commented 3 years ago

Don't allow autojoin FieldtypeSeoMaestro because saving data for the field does not work if this is activated

wanze commented 3 years ago

Hi @tiefenb

Thanks! Would it be possible to just disable the autojoin option and maybe add a note to the filed to explain that this option is not supported? I think it might be confusing for the user if this option is missing completely. Of course the real fix would be to check why saving data fails, but I currently don't have time to investigate.

Edit: If possible, could you also fix the style issues reported from StyleCI? Thanks 😄 https://github.styleci.io/analyses/d03KKb?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Cheers

tiefenb commented 3 years ago

Hi @wanze,

I am also not so deep into the autojoin topic. Some other PW Fieldtypes are also not autojoinable. I copied this from FieldtypeRepeater:

https://github.com/processwire/processwire/blob/master/wire/modules/Fieldtype/FieldtypeRepeater/FieldtypeRepeater.module#L1919

tiefenb commented 3 years ago

And sure will fix the StyleCI issues

wanze commented 3 years ago

Thanks! :)