Support Composer 2 with native Composer Installers

wanze / TemplateEngineFactory

🏭Provides ProcessWire integration for various template engines such as Twig.

MIT License

26 stars 11 forks source link

Support Composer 2 with native Composer Installers #19

Closed tiefenb closed 3 years ago

tiefenb commented 3 years ago

Support Composer 2 with native Composer Installers instead of hari/pw-module which does not support Composer 2

wanze commented 3 years ago

@tiefenb Cool, thanks! :)

Two questions as I don't know the Composer installer myself:

Does this also work for new installations with Composer 1, or is Composer 2 a requirement?
Is it possible to update the module via composer update if the current version is using hari-pw-module?

Also I just noticed that we should delete the composer.lock file from the repo, because dependencies should not be locked by the module but rather by the consumer's installation.

Cheers 🍻

tiefenb commented 3 years ago

Hi @wanze !

I guess Composer 2 is a requirement - maybe I have time to try it out soon.
Composer 2 does not support hari-pw-module. This bothered me since many month since Composer 1 is more and more depricated by many packages. But a new solution is made by @daun: https://github.com/composer/installers/pull/472

daun commented 3 years ago

composer/installers has been around for a while and works with Composer 1 and 2. At least I've been using it that way. No issues I can recall. The switch from hari to composer/installers has worked well for my modules and should improve compatibility since it supports Composer 1 and 2 while hari supports Composer 1 only.

wanze commented 3 years ago

Thanks for the nice explanation @tiefenb @daun 👍

Cheers