wapacro / az-keyvault-php

Library to easily work with Azure Key Vault using managed identities

https://packagist.org/packages/wapacro/az-keyvault-php

MIT License

18 stars 15 forks source link

Add Feature: List secrets in a specified key vault. #3

Closed litan1106 closed 3 years ago

litan1106 commented 4 years ago

2

wapacro commented 3 years ago

Hi @litan1106

Many thanks for your contribution. I'll review it in the upcoming days. In the meantime I'd ask you to provide some test cases for the new feature.

Best, Roman

litan1106 commented 3 years ago

Many thanks for your contribution. I'll review it in the upcoming days. In the meantime I'd ask you to provide some test cases for the new feature.

Best, Roman

Just added the getSecrets tests. Thanks https://github.com/wapacro/az-keyvault-php/pull/3/commits/8ed3d03a8e78c3664d02aecc0881efdf0e2c57d1