Switches module configuration to use writers

wapc / wapc-go

Golang-based WebAssembly Host Runtime for waPC-compliant modules

Apache License 2.0

91 stars 25 forks source link

Switches module configuration to use writers #35

Closed codefromthecrypt closed 2 years ago

codefromthecrypt commented 2 years ago

This uses more idiomatic types to implement logging and WASI streams. This also adds the missing stderr stream.

Fixes #19

codefromthecrypt commented 2 years ago

@pkedy the integration of dapr is blocked on this as I think they rightly think drift should occur pre-merge. Can you take a look sometime? Also, there are some remaining concerns noted in https://github.com/wapc/wapc-go/issues/34 so I may have a follow-up PR before or after dapr uses this depending on review availability in wapc-go

codefromthecrypt commented 2 years ago

ok I added a PR to help reduce review time as https://github.com/wapc/wapc-go/pull/36 will fix the other issue