search

wapc / wapc-rs

waPC Rust monorepo
Apache License 2.0
75 stars 9 forks source link

update wasmtime #57

Closed flavio closed 1 year ago

flavio commented 1 year ago

This is the usual PR that bumps the wasmtime version being consumed by the wasmtime-provider.

However, in addition to the dependency update, there's also a minor compilation fix. It turned out the wasmtime-provider didn't build when the wasi feature was disabled. I think this has been going on since quite some time, but we didn't notice. Some internal APIs have been changed to address the compilation error. Since the changes are not done to public APIs, there's no need to tag a major release of the crate.

There's however the need to do a minor bump of the crate and to publish that to allow everybody to benefit of the new version of wasmtime.

Changes to GH actions

Prior to this PR the GH action doing CI had just one step. This step performed the lint checks and then invoked cargo test --workspace. These tests however did not attempt to build the wasmtime-provider without the default features.

This PR splits the CI action into 3 steps, all running in parallel. One is doing linting, one running the worspace tests and another one doing the tests of wasmtime-provider (in this case testing both with default features enabled and disabled)

pkedy commented 1 year ago

@flavio https://crates.io/crates/wasmtime-provider/1.8.0

flavio commented 1 year ago

thanks!