wapc / wapc-rs

waPC Rust monorepo
Apache License 2.0
75 stars 9 forks source link

multiple fixes #86

Closed flavio closed 3 months ago

flavio commented 3 months ago

The automated release of wasmtime-provider v1.19.0 failed because of a discrepancy between the version of Rust used locally and on the remote branch. This PR contains several commits that bring more stability and consistency to the project.

Detailed changes

Update to latest stable release of Rust

Update to Rust 1.79.0. Also, make sure all the required targets are installed.

automation: uniform handling of Rust installation

Prior to this commit, the GH actions installed the rust toolchain using the now archived actions-rs/toolchain.

On top of that, the actions were installing latest stable release of Rust, overriding what was specified inside of our rust-toolchain.toml file. That lead to different behaviour locally and inside of the runners. For example, that caused the automated release of wasmtime-provider 1.19.0 to fail because of different clippy rules between the local development and the runners.

GitHub runners have rustup installed by default. That, together with our rust-toolchain.toml file is enough to get the right version of Rust automatically installed.

deps: update Rust's WASI target

The old wasm32-wasi target has been deprecated and is going to be completely replaced by wasm32-wasip1.

See this blog post.

This commit ensures we use the right WASI target.

As a final note, the .wasm file part of the commit is the same program rebuilt with the new target.

fixes: address linter warnings

Address all the linter warnings raised by latest version of clippy

What's next

Once this PR is merged, I'll tag a new release of wasmtime-provider: v1.19.1.