wapisai / pe

0 stars 0 forks source link

name is case sensitive #22

Open wapisai opened 5 months ago

wapisai commented 5 months ago

Screenshot 2024-04-19 at 5.07.27 PM.png

intput :John de

the case is preserved even thoguh names are not case sensitive

soc-pe-bot commented 5 months ago

Team's Response

It is mentioned in the UG (Main features -> Adding a person -> Notes about parameter format and behavior) that Names are case-sensitive. Based on the course guideline, it is considered as NotInScope

image.png

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Can add the same person twice by changing capitalisation in the names

image.png

Maybe just use phone number and email to check if the person is the same, no need to include name check as some people might have the same name.


[original: nus-cs2103-AY2324S2/pe-interim#4782] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is mentioned in the UG (Main features -> Adding a person -> Notes about parameter format and behavior) that Names are case-sensitive.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** ![Screenshot 2024-04-23 at 10.57.10 AM.png](https://raw.githubusercontent.com/wapisai/pe/main/files/5e51ecb3-27ac-44e8-9878-fc0b4c1401bf.png) ![Screenshot 2024-04-23 at 10.57.33 AM.png](https://raw.githubusercontent.com/wapisai/pe/main/files/c548facb-f053-4701-9b27-3d6b2406717f.png) As featureflaws can be considered not in scope except for the case that the feature can be implemented to work in a better way without much additional effort this featureflaw can be easily overcome by setting names to be fully capitalised, overcoming the problem of case sensitivity easily. thus should be accepted, not notinscope
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]