wapisai / pe

0 stars 0 forks source link

find command is abit weird #5

Open wapisai opened 5 months ago

wapisai commented 5 months ago

to find a person you have to type in their full name would cause an inconvenience to users if they cant remember a person's full name or have typo and inconvenient as they have to type the whole thing out

nus-se-script commented 5 months ago

Team's Response

It looks like there is some misunderstanding about find command. As mentioned in the userguide, find alex david returns a list that includes Alex Yeoh and David Li. You don't need to type full name to find a person. Only one word is required. The find command supports searching by other fields such as group, comment, email, and phone. Hence, even if you forget some information, you can use other fields to search the person. The reason why partial word search was disallowed was to increase accuracy. Partial word search might provide too much unwanted people with the keywords. There are both pros and cons to both method and our team decided that a complete word search is more appropriate because we have enough fields that are supported so forgetting some information does not affect that much. This is not a feature flaw, it is an expected behaviour.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This is a very unintuitive way to find usually find uses a substring to match

int his case you are using a full word to match which could cause a great hindrance to users if they are unable to remember the full word/ unsure of how to spell

to counter this u said that "The find command supports searching by other fields such as group, comment, email, and phone. Hence, even if you forget some information, you can use other fields to search the person." but im pretty sure if you are unable to remember someones name you are unlikely to remember their other fields like email and number or comment (i wonder if you have to remember the full field/word to search using these fields too)

your justification is that "Partial word search might provide too much unwanted people with the keywords" but if you are unable to remember the full word and instead want to search by other fields as group etc, im sure it will come up with way more irrelevant people than searching by substring

this is a featureflaw that is likely to cause great hindrance to users as i have already experienced while testing this and since this featureflaw is easily rectified by using search by substring, it should be accepted.