wapiti-scanner / wapiti

Web vulnerability scanner written in Python3
https://github.com/wapiti-scanner/wapiti
GNU General Public License v2.0
1.15k stars 176 forks source link

Fix the issue #559 #562

Closed OussamaBeng closed 6 months ago

OussamaBeng commented 6 months ago

Fixing the errors logging

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 73.33333% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 79.46%. Comparing base (206d6ec) to head (d1a3065).

:exclamation: Current head d1a3065 differs from pull request most recent head 54e82b7. Consider uploading reports for the commit 54e82b7 to get more accurate results

Files Patch % Lines
wapitiCore/main/wapiti.py 69.56% 7 Missing :warning:
wapitiCore/controller/wapiti.py 58.33% 5 Missing :warning:
wapitiCore/attack/mod_wapp.py 84.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #562 +/- ## ========================================== + Coverage 79.36% 79.46% +0.10% ========================================== Files 113 113 Lines 9323 9364 +41 ========================================== + Hits 7399 7441 +42 + Misses 1924 1923 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Qwarctick commented 6 months ago

Note: This PR is related to https://github.com/wapiti-scanner/wapiti/issues/559

I think this does not work as expected. If I try your code :

bin/wapiti --update --wapp-url qwerty

 ██╗    ██╗ █████╗ ██████╗ ██╗████████╗██╗██████╗
 ██║    ██║██╔══██╗██╔══██╗██║╚══██╔══╝██║╚════██╗
 ██║ █╗ ██║███████║██████╔╝██║   ██║   ██║ █████╔╝
 ██║███╗██║██╔══██║██╔═══╝ ██║   ██║   ██║ ╚═══██╗
 ╚███╔███╔╝██║  ██║██║     ██║   ██║   ██║██████╔╝
  ╚══╝╚══╝ ╚═╝  ╚═╝╚═╝     ╚═╝   ╚═╝   ╚═╝╚═════╝
Wapiti 3.1.8 (wapiti-scanner.github.io)
[*] Updating modules
Updating module htp
Update done.
Updating module wapp
Error: Non-200 status code for _.json. Skipping.
RequestError occurred: Request URL is missing an 'http://' or 'https://' protocol.
RequestError during update: Request URL is missing an 'http://' or 'https://' protocol.
[!] Module wapp seems broken and will be skipped
Updating module nikto
Update done.
Error: None is not a valid domain name

You should have one or two error message, not duplicate of them. And there is a mix of error message.

Qwarctick commented 6 months ago

Seems good 👍

$ bin/wapiti --update --wapp-url kjhdsdkfhdsf

 ██╗    ██╗ █████╗ ██████╗ ██╗████████╗██╗██████╗
 ██║    ██║██╔══██╗██╔══██╗██║╚══██╔══╝██║╚════██╗
 ██║ █╗ ██║███████║██████╔╝██║   ██║   ██║ █████╔╝
 ██║███╗██║██╔══██║██╔═══╝ ██║   ██║   ██║ ╚═══██╗
 ╚███╔███╔╝██║  ██║██║     ██║   ██║   ██║██████╔╝
  ╚══╝╚══╝ ╚═╝  ╚═╝╚═╝     ╚═╝   ╚═╝   ╚═╝╚═════╝
Wapiti 3.1.8 (wapiti-scanner.github.io)
[*] Updating modules
Updating module wapp
Error: kjhdsdkfhdsf is not a valid URL
Invalid Option Error :
[!] Module wapp seems broken and will be skipped
Updating module nikto
Update done.
Updating module htp
Update done.
Error: None is not a valid domain name