Closed devl00p closed 2 months ago
Attention: Patch coverage is 82.81938%
with 39 lines
in your changes missing coverage. Please review.
Project coverage is 79.53%. Comparing base (
3a0f685
) to head (cf646d7
).
Files | Patch % | Lines |
---|---|---|
wapitiCore/attack/mod_ssl.py | 82.81% | 39 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
related to https://github.com/wapiti-scanner/wapiti/issues/553
Did a simple check for a pattern in crt.sh responses for CT logs.
Hi @devl00p,
I think we should remove ssl
from common_modules
here : https://github.com/wapiti-scanner/wapiti/blob/master/wapitiCore/attack/attack.py#L81 since sslscan
is not installed by default.
Hi @devl00p, I think we should remove
ssl
fromcommon_modules
here : https://github.com/wapiti-scanner/wapiti/blob/master/wapitiCore/attack/attack.py#L81 sincesslscan
is not installed by default.
Hello,
No, this is on purpose to encourage users to install the dependency. They wil just get a warning telling them to install sslscan.
No, this is on purpose to encourage users to install the dependency. They wil just get a warning telling them to install sslscan.
I does not work. If sslscan is not installed, subprocess will raise a FileNotFoundError
and stop the execution. You will not have the correct warning.
EDIT: My bad, it does not work only in tests. It works in "normal" execution.
Theer is still an issue related to certificate transparency logs.
Can't tell at the moment if crt.sh is broken or if I should do things differently.