wapiti-scanner / wapiti

Web vulnerability scanner written in Python3
https://github.com/wapiti-scanner/wapiti
GNU General Public License v2.0
1.15k stars 176 forks source link

Refactor definitions #606

Closed devl00p closed 1 month ago

devl00p commented 1 month ago

This MR refactors the attributes of each definition, which were previously held as module constants, into separate classes named "findings".

Purpose:

If a finding can be categorized as both a vulnerability and an additional type, separate finding classes should be created for each category.

fwininger commented 1 month ago

@bretfourbe peux tu regarder les implications pour nous.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 93.23374% with 77 lines in your changes missing coverage. Please review.

Project coverage is 80.40%. Comparing base (7e84c4c) to head (5ca9ce1). Report is 1 commits behind head on master.

Files Patch % Lines
wapitiCore/definitions/base.py 75.75% 8 Missing :warning:
wapitiCore/definitions/xpath.py 75.00% 6 Missing :warning:
wapitiCore/attack/mod_xxe.py 60.00% 4 Missing :warning:
wapitiCore/definitions/xxe.py 83.33% 4 Missing :warning:
wapitiCore/attack/mod_sql.py 62.50% 3 Missing :warning:
wapitiCore/definitions/http_headers.py 95.58% 3 Missing :warning:
wapitiCore/attack/mod_csp.py 33.33% 2 Missing :warning:
wapitiCore/attack/mod_exec.py 71.42% 2 Missing :warning:
wapitiCore/attack/mod_file.py 66.66% 2 Missing :warning:
wapitiCore/attack/mod_http_headers.py 60.00% 2 Missing :warning:
... and 39 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #606 +/- ## ========================================== + Coverage 79.61% 80.40% +0.78% ========================================== Files 123 124 +1 Lines 10431 11125 +694 ========================================== + Hits 8305 8945 +640 - Misses 2126 2180 +54 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

devl00p commented 1 month ago

Another significant change: the HTTP headers definitions are now split into 3 separate findings: