wapmorgan / Morphos

A morphological solution for Russian and English language written completely in PHP. Provides classes to inflect personal names, geographical names, decline and pluralize nouns, generate cardinal and ordinal numerals, spell out money amounts and time intervals. / Морфологическая библиотека для английского и русского языков. Склоняет имена собственные, названия географических объектов, склонение и плюрализация имен собственных и другое.
http://wapmorgan.github.io/Morphos/
MIT License
788 stars 105 forks source link

Idiotic api change #16

Closed alpha-and-omega closed 7 years ago

alpha-and-omega commented 7 years ago

Change order of arguments of pluralize() Suck you!

alpha-and-omega commented 7 years ago

At least make it order-agnostic, this broke my production system.

wapmorgan commented 7 years ago

Sorry for inconvenience that this change was made without increasing minor version part of Morphos. You can downgrade to any version prior 3.2.2 (e.g. 3.2.1 or 3.2.0), in which this update was made, and pluralize will work as expected.

alpha-and-omega commented 7 years ago

You also changed output format, uhgggg! 3.0.9 actually.

wapmorgan commented 6 years ago

I've updated pluralize() and NounPluralization::pluralize() in 3.2.7: now you can swap arguments and result will be the same: pluralize('дом', 2) and pluralize(2, 'дом') are identical