wapmorgan / PhpDeprecationDetector

Analyzer of PHP code to search issues with deprecated functionality in newer interpreter versions.
http://wapmorgan.github.io/PhpDeprecationDetector/
BSD 3-Clause "New" or "Revised" License
364 stars 37 forks source link

FP: mb_ereg_replace #67

Open voku opened 2 years ago

voku commented 2 years ago

Hi, I see errors like this:

| /thirdparty/composer/voku/portable-utf8/src/voku/helper/UTF8.php:5804                              | removed   | Function mb_ereg_replace() is removed.                                           |
|                                                                                                    |           | Consider replace with @mb_ereg_replace_e_modifier()                              |
|

... but mb_ereg_replace is not removed and mb_ereg_replace_e_modifier does not exist. I think you will check the "e" modifier usage somehow here, but the error message seems not correct here.

wapmorgan commented 2 years ago

Agreed, information is not full. Unfortunately, I don't have time to work on opensource, so let issue be open

NathanGibbs3 commented 1 year ago

Hi, I see errors like this:

| /thirdparty/composer/voku/portable-utf8/src/voku/helper/UTF8.php:5804                              | removed   | Function mb_ereg_replace() is removed.                                           |
|                                                                                                    |           | Consider replace with @mb_ereg_replace_e_modifier()                              |
|

... but mb_ereg_replace is not removed and mb_ereg_replace_e_modifier does not exist. I think you will check the "e" modifier usage somehow here, but the error message seems not correct here.

If you can throw some proof of concept code in here that will trip this error, I'll see what I can do about putting a PR together that will fix it.