search

waqasbhatti / astrobase

Python modules for light curve work and variable star astronomy
MIT License
55 stars 12 forks source link

checkplotserver creating new checkplot pickles #52

Closed joshuawallace closed 6 years ago

joshuawallace commented 6 years ago

I have some checkplot pickles that were created in a script running Python 2. I viewed them with a checkplotserver, but every time I went back to look at them my previous comments and classifications were not there. I discovered that new checkplot pickles were being created using the object IDs. I do not have this problem with my checkplot pickles that were made using Python 3.

waqasbhatti commented 6 years ago

Sounds like a bug alright. Can you send over a couple of the ones you created in Python 2? I'll take a look.

waqasbhatti commented 6 years ago

I'm working on this now. Can reproduce the weirdness here.

waqasbhatti commented 6 years ago

Sorry for the delay. I believe 77b1596 should fix this. It was a forgotten check for Unicode filenames in Python 2.7. Tested it with the checkplot pickles you sent and it appeared to work OK.

joshuawallace commented 6 years ago

Looks like it's working for me.