periodbase: add transit least squares

waqasbhatti / astrobase

Python modules for light curve work and variable star astronomy

MIT License

55 stars 12 forks source link

Closed lgbouma closed 5 years ago

lgbouma commented 5 years ago

This commit adds a wrapper to Hippke and Heller's transit least squares package (2019; arxiv.org/abs/1901.02015).

A few comments:

test_tls_parallel() passes
the resultdict returned by tls_parallel_pfind doesn't exactly match the astrobase standard, because of the details of the transitleastsquares inputs/outputs. In particular, this wrapper relinquishes control of the frequency grid, in favor of the one Hippke & Heller implemented.
a review before merging would be appreciated!

waqasbhatti commented 5 years ago

Thanks for the PR! Looks OK at first glance; I'll review this later today or by Tuesday at the latest.

lgbouma commented 5 years ago

Done on all counts, and the test is passing. I think it's ready to merge!

waqasbhatti commented 5 years ago

Thanks for the update. Will merge this tomorrow after I make sure the CI job knows to install transitleastsquares as well.