search

waqasbhatti / astrobase

Python modules for light curve work and variable star astronomy
MIT License
55 stars 12 forks source link

Possible bug in CSV file update for checkplots #85

Closed joshuawallace closed 4 years ago

joshuawallace commented 5 years ago

I was looking at the CSV file generated by the checkplot server for all the checkplots I looked at. I noticed that the varinfo.objectisvar flag was sometimes set to a decimal number (rather than 1, 2, or 3), and sometimes corresponding the varinfo.varperiod was set to 1, 2, or 3. I was thinking that maybe the two of these were sometimes getting switched? Here's a screenshot. screenshot_varinfo

waqasbhatti commented 5 years ago

Yep, this is probably a bug somewhere in the JS for the frontend. Can you point me to the checkplotlist JSON file for this session?

waqasbhatti commented 5 years ago

Can you try the latest github master? I think the issue was not adding in blank values in the CSV row for missing objectinfo keys.

joshuawallace commented 4 years ago

Sorry I never got around to checking this.

On Sun, Jun 21, 2020 at 6:52 PM Waqas Bhatti notifications@github.com wrote:

Closed #85 https://github.com/waqasbhatti/astrobase/issues/85.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/waqasbhatti/astrobase/issues/85#event-3466026290, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGVIFU3RL7L3GJODHIKX2TRX2TNVANCNFSM4HLNFAJA .

waqasbhatti commented 4 years ago

I think I got it working, but it's all moot now :-)

On Sun, Jun 21, 2020 at 10:29 PM Joshua notifications@github.com wrote:

Sorry I never got around to checking this.

On Sun, Jun 21, 2020 at 6:52 PM Waqas Bhatti notifications@github.com wrote:

Closed #85 https://github.com/waqasbhatti/astrobase/issues/85.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/waqasbhatti/astrobase/issues/85#event-3466026290, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABGVIFU3RL7L3GJODHIKX2TRX2TNVANCNFSM4HLNFAJA

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/waqasbhatti/astrobase/issues/85#issuecomment-647232734, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOIDGCNU2VPZTWWKDXSLS3RX26Z5ANCNFSM4HLNFAJA .