search

warashibe / nextdapp

(D)App Development Kit powered by Next.js and Facebook Recoil
https://nextdapp.org
MIT License
45 stars 3 forks source link

delete nd/conf.js from gitignore #124

Closed dmamira closed 4 years ago

dmamira commented 4 years ago

nd/conf.js is a file that does not contain a private key. So I don't think it's necessary to add it to gitignore. If this is added to gitignore, auto-deploy to vercel won't work.

ocrybit commented 4 years ago

You are right, I don't auto-deploy Next Dapp Apps via Github, and I didn't want to commit the Firebase configurations (which are OK to be inlined and revealed) to any public repo, but If you are auto-deploying via Github, I agree /nd/conf.js needs to go through Github or any other CI workflow.

dmamira commented 4 years ago

Thank you.

ocrybit commented 4 years ago

On second thought, I actually re-excluded nd/conf.* #129 because the actual repository nextdapp-cli is cloning when nextdapp create [project-name] executes is located at https://github.com/warashibe/next-dapp-bare and this repository (next-dapp) is a showcase of what Next Dapp can do. So next-dapp-bare repository has been modified to NOT exclude nd/con.* files, but this repository stays what It used to be without including nd/conf.* files, so we don't expose anyone's Firebase configurations to be abused.