search

warchimede / RangeSlider

A simple range slider made in Swift
MIT License
366 stars 78 forks source link

Added move thumbs by touch + fix for stuck thumbs #28

Open GiladR1979 opened 6 years ago

GiladR1979 commented 6 years ago

Now touching slider moves the closest thumb to touch point. Also- fixed a bug- when two thumbs are at the extreme- trying to drag open the range doesn't work because the most extreme thumb gets the touch (instead of the inner thumb that needs to move). Also, dragging one thumb over the other opens the range in the opposite direction (the thumbs "flip sides" and continue to move).

scottcc commented 6 years ago

Not that I have any say in this project really (but I do use it) - but the indentation you got going on in this patch is whack. Can't really see what's changing, looks like everything is.

Sundin commented 6 years ago

I agree with @scottcc, and another thing (please consider it constructive feedback! 😃 ): it's no point keeping code that you have commented away in your commit, in case anybody needs that code back, it always remain in the git history.