ward-wise / data-analysis

Data analysis on Chicago infrastructure and infrastructure spending
MIT License
3 stars 7 forks source link

Add Ruff for formatting and linting #39

Closed suryadutta closed 3 weeks ago

suryadutta commented 3 months ago

Ruff is an extremely performant and opinionated Python linter and formatter. This PR proposes adding it to this project.

After introducing this change:

smacmullan commented 3 months ago

I'm still having Windows-specific issues (I'll probably switch to a container setup next time I go to do work on this repo). I support adding the linter, someone else will need to test it out.

suryadutta commented 3 months ago

I'm still having Windows-specific issues (I'll probably switch to a container setup next time I go to do work on this repo). I support adding the linter, someone else will need to test it out.

@smacmullan Sorry you're having these issues - I started drafting a PR for running these commands in Docker here: https://github.com/ward-wise/data-analysis/pull/40/files

Also happy to try debugging the issues you're running into

simplicio10 commented 3 months ago

@suryadutta I checked this out to take a look. I haven't used Ruff before and want to make sure I'm doing it right. I'll play around a bit today and may have some questions at tonight's open hack if you'll be there.

In general, this looks great so I don't imagine there will be any issues.