Closed suryadutta closed 3 weeks ago
I'm still having Windows-specific issues (I'll probably switch to a container setup next time I go to do work on this repo). I support adding the linter, someone else will need to test it out.
I'm still having Windows-specific issues (I'll probably switch to a container setup next time I go to do work on this repo). I support adding the linter, someone else will need to test it out.
@smacmullan Sorry you're having these issues - I started drafting a PR for running these commands in Docker here: https://github.com/ward-wise/data-analysis/pull/40/files
Also happy to try debugging the issues you're running into
@suryadutta I checked this out to take a look. I haven't used Ruff before and want to make sure I'm doing it right. I'll play around a bit today and may have some questions at tonight's open hack if you'll be there.
In general, this looks great so I don't imagine there will be any issues.
Ruff is an extremely performant and opinionated Python linter and formatter. This PR proposes adding it to this project.
After introducing this change:
the command
make format
will automatically format the code based on PEP8 standards, similar to theblack
autoformatter==
operator or not". Everything is fixed automatically.the command
make lint
will automatically lint the code similar to static analysis tools likeflake8
,isort
, and more